Skip to content

Conversation

@shs96c
Copy link
Contributor

@shs96c shs96c commented Dec 6, 2024

No description provided.

@shs96c shs96c requested a review from aignas as a code owner December 6, 2024 16:58
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougthor42
Copy link
Collaborator

I ran this locally and didn't see any issues 🎉. The previous comments still need to be addressed though.

@aignas aignas requested a review from dougthor42 December 17, 2024 08:17
Copy link
Collaborator

@dougthor42 dougthor42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a whitespace nit but otherwise LGTM. When that's fixed I'll give the 👍

Copy link
Collaborator

@dougthor42 dougthor42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dougthor42
Copy link
Collaborator

@aignas @rickeylev I'm not yet super familiar with the CI pipeline, so I'm not sure if that buildkite failure is a blocker or not, or if it's just a flake.

@shs96c
Copy link
Contributor Author

shs96c commented Dec 19, 2024

I think this was just a flaky run: could not download Bazel: failed to download bazel: failed to download bazel:.

If someone with BuildKite permissions is around, there's a "retry" button, which will allow that one build to be retried.

@aignas aignas enabled auto-merge March 7, 2025 04:36
@aignas aignas added this pull request to the merge queue Mar 7, 2025
Merged via the queue into bazel-contrib:main with commit b499560 Mar 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants